Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESLint 8.x #218

Closed
Tracked by #7
, #193 ,  #2
...
MichaelDeBoey opened this issue Sep 4, 2021 · 5 comments · Fixed by #219
Closed
Tracked by #7
, #193 ,  #2
...

Support ESLint 8.x #218

MichaelDeBoey opened this issue Sep 4, 2021 · 5 comments · Fixed by #219

Comments

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Sep 4, 2021 •
edited
Loading

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂
@MichaelDeBoey MichaelDeBoey mentioned this issue Sep 4, 2021
Merged
63 tasks
@theoludwig theoludwig mentioned this issue Oct 10, 2021
Merged
3 tasks
This was referenced Oct 10, 2021
Merged
Closed
Merged
@Sparticuz Sparticuz mentioned this issue Oct 12, 2021
Closed
51 tasks
@fujikky fujikky mentioned this issue Oct 13, 2021
Merged
1 task
@calebeby calebeby mentioned this issue Oct 15, 2021
Closed
1 task
@Belco90 Belco90 mentioned this issue Oct 17, 2021
Closed
66 tasks
@niksy niksy mentioned this issue Oct 18, 2021
Closed
11 tasks
@jenssimon jenssimon mentioned this issue Oct 21, 2021
Closed
6 tasks
This was referenced Oct 30, 2021
Closed
Closed
@willdurand willdurand mentioned this issue Nov 2, 2021
Merged
3 tasks
@lukashass lukashass mentioned this issue Nov 4, 2021
Closed
12 tasks
thewilkybarkid added a commit to PREreview/prereview that referenced this issue Nov 26, 2021
@thewilkybarkid
chore(deps): use ESLint 7.32.0
63a607a 
ESLint 8 is available, but eslint-plugin-promise doesn't yet support it.

Refs #422, eslint-community/eslint-plugin-promise#218
@atjn atjn mentioned this issue Dec 1, 2021
Closed
2 tasks
@D4N14L D4N14L mentioned this issue Dec 1, 2021
Merged
Jason3S added a commit to streetsidesoftware/cspell that referenced this issue Dec 7, 2021
@Jason3S
ci: Remove eslint-plugin-promise
d1efa47 
Add it back when [Support ESLint 8.x · Issue #218 · xjamundx/eslint-plugin-promise](eslint-community/eslint-plugin-promise#218) is resolved.
This was referenced Dec 7, 2021
Merged
Closed
Jason3S added a commit to streetsidesoftware/cspell that referenced this issue Dec 7, 2021
@Jason3S
ci: Remove eslint-plugin-promise (#2076)
df247c7 
* ci: Remove eslint-plugin-promise

Add it back when [Support ESLint 8.x · Issue #218 · xjamundx/eslint-plugin-promise](eslint-community/eslint-plugin-promise#218) is resolved.
@Romick2005
Copy link
Contributor

Romick2005 commented Dec 7, 2021 •
edited
Loading

image
This means that this package require updating eslint version. I think that just up eslint version to the latest would not break anything and it is easy to do.

@doberkofler
Copy link

Support for eslint 8 would be most appreciated.

@rtrembecky
Copy link

@doberkofler ESLint 8 is supported as of 1.0.8: https://github.com/microsoft/rushstack/blob/master/eslint/eslint-patch/CHANGELOG.md#108
I just went to upgrade my ESLint plugins and configs and I'm running ESLint 8 with @rushstack/eslint-patch of 1.1.0 with no issues.

@xjamundx
Copy link
Contributor

xjamundx commented Dec 18, 2021 •
edited
Loading

@MichaelDeBoey what do you actually want me to do here? like just update the dev dep to eslint 8 or is there something else? I updated all the deps I could find. Personally I'm 100% fine dropping all linting plugins for this repo (ironically). It's a bit of a circular dependency nightmare IMO

@MichaelDeBoey
Copy link
Member Author

@xjamundx I have #219 to support ESLint v8, but that PR is dependent on #239

@D4N14L D4N14L mentioned this issue Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support ESLint 8.x MichaelDeBoey/eslint-plugin-promise
5 participants
@xjamundx @doberkofler @rtrembecky @MichaelDeBoey @Romick2005