Fix: no-deprecated-report-api should consider spread operator(fixes #64)

eslint-community · Oct 24, 2018 · 5473e50 · 5473e50
1 parent a128650
commit 5473e50
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/no-deprecated-report-api.js b/lib/rules/no-deprecated-report-api.js
@@ -39,7 +39,7 @@ module.exports = {
           node.callee.type === 'MemberExpression' &&
           contextIdentifiers.has(node.callee.object) &&
           node.callee.property.type === 'Identifier' && node.callee.property.name === 'report' &&
-          node.arguments.length > 1
+          (node.arguments.length > 1 || (node.arguments.length === 1 && node.arguments[0].type === 'SpreadElement'))
         ) {
           context.report({
             node: node.callee.property,

diff --git a/tests/lib/rules/no-deprecated-report-api.js b/tests/lib/rules/no-deprecated-report-api.js
@@ -209,5 +209,16 @@ ruleTester.run('no-deprecated-report-api', rule, {
       output: null,
       errors: [ERROR],
     },
+    {
+      code: `
+        module.exports = {
+          create(context) {
+            context.report(...error);
+          }
+        };
+      `,
+      output: null,
+      errors: [ERROR],
+    },
   ],
 });