Create Inheritable Logger Class #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed uselss import from the ISR test file
erunks
force-pushed
the
create-inheritable-logger
branch
from
c7b4178 to
a87e75b
Compare
erunks
force-pushed
the
create-inheritable-logger
branch
from
a87e75b to
07f9bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As we're developing new features and log points, it became quickly apparent that the
MailLoggerwas needed to provide an easy logging setup to other classes.Changes
MailLoggerclass which has all the setup work involved for creating a logger that will send emailsMailLoggerInternetStatusReporterto inherit theMailLoggerclass, and removed the old setup for the loggerInternetStatusReporterto remove a useless import.gitignore