Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust logging #16

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Add more robust logging #16

merged 2 commits into from
Jan 10, 2021

Conversation

erunks
Copy link
Owner

@erunks erunks commented Jan 10, 2021

What

After updating the parser from lxml to html.parser, we began running into some SQL syntax errors, which are hard to solve without knowing what the SQL trying to be executed was. This PR adds some extra logging in places where we can gain that insight.

Changes

  • Added
    • extra info logs for when errors happen here in the future, involving SQL execution
  • Updated
    • the requirements file to make sure the version of pip is up to date

erunks added 2 commits January 9, 2021 21:43
…This way the SQL query is replicatable in order to fix the error.
…p to date. Otherwise some packages may not be found
@erunks erunks merged commit 270bb2c into master Jan 10, 2021
@erunks erunks deleted the add-refined-logs branch January 10, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant