Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sass/LESS mappings for Weather Underground API #104

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Add Sass/LESS mappings for Weather Underground API #104

merged 1 commit into from
Sep 14, 2015

Conversation

chriseverson
Copy link
Contributor

This commit adds Sass and LESS mappings for the Weather Underground API.

Neither has been compiled down to CSS in this commit as I wasn't sure on the exact preferred compile settings for this project.

@erikflowers
Copy link
Owner

This looks good, I will take it over and recompile and upload.

I use Codekit to compile and work on the project: https://incident57.com/codekit/, which is simple for the weather API mappings, but it gets a lot more complicated with the main files that run through the ./wbuilder app in the _builder folder that exports the css, jade, and index files as well.

So you did the right thing.

@erikflowers erikflowers reopened this Sep 14, 2015
erikflowers added a commit that referenced this pull request Sep 14, 2015
Add Sass/LESS mappings for Weather Underground API
@erikflowers erikflowers merged commit 6156123 into erikflowers:master Sep 14, 2015
@erikflowers
Copy link
Owner

There were some issues with the Less file, the syntax wasn't right, it was sort of a mix of Less and Sass. So I fixed it and compiled, so you'll want to replace your files with the new ones. I also added a -wu prefix since some of the classes would overwrite the Weather Icons classes

https://github.com/erikflowers/weather-icons/blob/master/less/mappings/wi-wunderground.less
https://github.com/erikflowers/weather-icons/blob/master/sass/mappings/wi-wunderground.scss

But thanks for doing this, was easy to fix and add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants