nilness linter #13146
Merged
nilness linter #13146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeepdino008
commented
Dec 17, 2024
| @@ -131,7 +131,7 @@ func (g *GossipManager) onRecv(ctx context.Context, data *sentinel.GossipData, l | |||
| if errors.Is(err, services.ErrIgnore) || errors.Is(err, synced_data.ErrNotSynced) { | |||
| return nil | |||
| } | |||
| if err != nil { | |||
There was a problem hiding this comment.
not sure what to do in these cases...so keeping existing behavior. cc: @Giulio2002
sudeepdino008
requested review from
AskAlexSharov and
Giulio2002
and removed request for
AskAlexSharov
| @@ -1254,7 +1254,7 @@ func doCompress(cliCtx *cli.Context) error { | |||
| default: | |||
| } | |||
| } | |||
| if err != nil && !errors.Is(err, io.EOF) { | |||
| if !errors.Is(err, io.EOF) { | |||
There was a problem hiding this comment.
i did use this command - why did it work?
There was a problem hiding this comment.
err != nil is redundant check. It'll always be the case here...so this doesn't change behavior.
AskAlexSharov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.