Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to two random attestation subnets #12254

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

shotasilagadze
Copy link
Contributor

@shotasilagadze shotasilagadze commented Oct 9, 2024

randomly choosing two attestation subnets and subscribing indefinitely.

@shotasilagadze shotasilagadze force-pushed the max-attestation-subnets branch 2 times, most recently from 1e53efb to d6a8526 Compare October 9, 2024 10:07
@shotasilagadze shotasilagadze changed the title limit number of attestation subnets Listen to two random attestation subnets Oct 9, 2024
@Giulio2002
Copy link
Contributor

Giulio2002 commented Oct 10, 2024

Mh, still not quite right - subscription should happen it is just that 2 random subnets should not have expiry time of 0.

I would just pick a number from [0, SUBNET_COUNT) and then instead of calling getExpiryTime - just give it the time math.MaxUint64

@shotasilagadze shotasilagadze force-pushed the max-attestation-subnets branch 2 times, most recently from ff941ef to 441e4de Compare October 10, 2024 13:55
@shotasilagadze shotasilagadze force-pushed the max-attestation-subnets branch from 441e4de to e4b7f24 Compare October 10, 2024 14:12
@Giulio2002 Giulio2002 enabled auto-merge (squash) October 10, 2024 14:16
@Giulio2002 Giulio2002 merged commit 39b62b4 into main Oct 10, 2024
11 checks passed
@Giulio2002 Giulio2002 deleted the max-attestation-subnets branch October 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants