Skip to content

Commit

Permalink
Caplin: Fix blob_sidecars API field name (#10342)
Browse files Browse the repository at this point in the history
Commitment inclusion proof field name is called
`kzg_commitment_inclusion_proof` in the beacon node API spec.

---------

Co-authored-by: Adrian Bacircea <[email protected]>
  • Loading branch information
Giulio2002 and adytzu2007 authored May 15, 2024
1 parent c198e5a commit b4a4058
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cl/beacon/handler/test_data/blob_sidecars_1.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions cl/cltypes/blob_sidecar.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type BlobSidecar struct {
KzgCommitment libcommon.Bytes48 `json:"kzg_commitment"`
KzgProof libcommon.Bytes48 `json:"kzg_proof"`
SignedBlockHeader *SignedBeaconBlockHeader `json:"signed_block_header"`
CommitmentInclusionProof solid.HashVectorSSZ `json:"proof"`
CommitmentInclusionProof solid.HashVectorSSZ `json:"kzg_commitment_inclusion_proof"`
}

func NewBlobSidecar(index uint64, blob *Blob, kzgCommitment libcommon.Bytes48, kzgProof libcommon.Bytes48, signedBlockHeader *SignedBeaconBlockHeader, commitmentInclusionProof solid.HashVectorSSZ) *BlobSidecar {
Expand All @@ -46,7 +46,7 @@ func (b *BlobSidecar) UnmarshalJSON(buf []byte) error {
KzgCommitment libcommon.Bytes48 `json:"kzg_commitment"`
KzgProof libcommon.Bytes48 `json:"kzg_proof"`
SignedBlockHeader *SignedBeaconBlockHeader `json:"signed_block_header"`
CommitmentInclusionProof solid.HashVectorSSZ `json:"proof"`
CommitmentInclusionProof solid.HashVectorSSZ `json:"kzg_commitment_inclusion_proof"`
}
tmp.Blob = &Blob{}
tmp.CommitmentInclusionProof = solid.NewHashVector(CommitmentBranchSize)
Expand Down
2 changes: 1 addition & 1 deletion cl/persistence/base_encoding/rabbit.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
)

func WriteRabbits(in []uint64, w io.Writer) error {
// Retrieve compressor first
// Retrieve compressor first.
compressor := compressorPool.Get().(*zstd.Encoder)
defer compressorPool.Put(compressor)
compressor.Reset(w)
Expand Down

0 comments on commit b4a4058

Please sign in to comment.