Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code work on Julia 1.3 #8

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Make the code work on Julia 1.3 #8

merged 3 commits into from
Mar 8, 2021

Conversation

ericphanson
Copy link
Owner

@ericphanson ericphanson commented Mar 8, 2021

address JuliaRegistries/General#31530

We only need it to be importable, but that's basically the same as runnable since all the changes are just syntax, and might as well make the tests work too so we have CI and can be sure it will continue to work on 1.3.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #8 (9fbc254) into main (23ce74b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines            5        36   +31     
=========================================
+ Hits             5        36   +31     
Impacted Files Coverage Δ
src/LicenseCheck.jl 100.00% <100.00%> (ø)
src/find_licenses.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a94bfc...9fbc254. Read the comment docs.

@ericphanson ericphanson merged commit 2c22cb2 into main Mar 8, 2021
@ericphanson ericphanson deleted the eph/1p3 branch March 8, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant