Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NUL string error #7

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Fix NUL string error #7

merged 4 commits into from
Feb 17, 2021

Conversation

ericphanson
Copy link
Owner

@ericphanson ericphanson commented Feb 16, 2021

#6 with a test added.

Closes #6

(I tried pushing a commit but it made a local branch instead, hence this separate PR)

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #7 (77922cf) into main (23ce74b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines            5        35   +30     
=========================================
+ Hits             5        35   +30     
Impacted Files Coverage Δ
src/LicenseCheck.jl 100.00% <100.00%> (ø)
src/find_licenses.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bc603...77922cf. Read the comment docs.

@giordano
Copy link
Contributor

I wanted to add also a test that makes sure license_table fails when validate_strings=false

@giordano
Copy link
Contributor

But besides that, the test is perfect 🙂

@ericphanson
Copy link
Owner Author

Good call! Added

@ericphanson ericphanson merged commit 0a94bfc into main Feb 17, 2021
@ericphanson ericphanson deleted the mg/safer-string branch February 17, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants