Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with Brunch's command-line tests. #190

Closed
wants to merge 1 commit into from

Conversation

rtfeldman
Copy link

Although the nodejs branch provides standalone NodeJS test functionality, evidently all that's needed to get them working with Brunch (http://brunch.io) tests is to give canvasses a default style object. (And having jsdom and canvas installed, of course.)

Without this, trying to run Brunch tests involving Kinetic fail because Layer tries to set this.canvas.getElement().style.position = 'absolute' and evidently jsdom's implementation of canvas does not give it a default style object.

With this change, the style object is guaranteed to exist, and Brunch tests work.

@ericdrowell
Copy link
Owner

Haven't forgotten about this - will add it in as soon as I get the chance (been pretty swamped lately)

@lavrton
Copy link
Contributor

lavrton commented Feb 27, 2014

I added this with nodejs support commit.

@lavrton lavrton closed this Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants