Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Extract ComposerJsonNormalizer #8

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Enhancement: Extract ComposerJsonNormalizer #8

merged 1 commit into from
Jan 13, 2018

Conversation

localheinz
Copy link
Member

This PR

  • extracts a ComposerJsonNormalizer

@localheinz localheinz self-assigned this Jan 13, 2018
@localheinz localheinz force-pushed the feature/composer-json-normalizer branch 2 times, most recently from f1f5180 to ceef185 Compare January 13, 2018 20:05
@codecov
Copy link

codecov bot commented Jan 13, 2018 •
edited
Loading

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #8   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       29     33    +4     
=======================================
  Files             4      5    +1     
  Lines           106    114    +8     
=======================================
+ Hits            106    114    +8
Impacted Files Coverage Δ Complexity Δ
src/Normalizer/ComposerJsonNormalizer.php 100% <100%> (ø) 4 <4> (?)
src/NormalizePlugin.php 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71925a...ac55429. Read the comment docs.

@localheinz localheinz force-pushed the feature/composer-json-normalizer branch from ceef185 to d3893e7 Compare January 13, 2018 20:26
localheinz
localheinz commented Jan 13, 2018
View reviewed changes
test/Unit/Normalizer/ComposerJsonNormalizerTest.php

final class ComposerJsonNormalizerTest extends AbstractNormalizerTestCase
{
public function testComposesNormalizers()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly, but better than nothing for now.

@localheinz localheinz force-pushed the feature/composer-json-normalizer branch from d3893e7 to 70b5011 Compare January 13, 2018 20:50
@localheinz localheinz force-pushed the feature/composer-json-normalizer branch from 70b5011 to ac55429 Compare January 13, 2018 20:53
@localheinz localheinz merged commit d65d6a9 into master Jan 13, 2018
@localheinz localheinz deleted the feature/composer-json-normalizer branch January 13, 2018 21:02
localheinz added a commit that referenced this pull request Jan 13, 2018
@localheinz
Merge pull request #8 from localheinz/feature/composer-json-normalizer
393b8a2 
Enhancement: Extract ComposerJsonNormalizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz