Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use --no-scripts option when invoking UpdateCommand #19

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 16, 2018

This PR

  • uses the --no-scripts option when invoking the UpdateCommand

Follows #15 (comment).

💁‍♂️ For reference, see https://getcomposer.org/doc/03-cli.md#update:

Options

  • --no-scripts: Skips execution of scripts defined in composer.json.

This suppresses scripts, for example, when having installed symfony/thanks, it prevents rendering the suggestion to send ⭐️s (see Symfony\Thanks\Thanks.

Thank you, @soullivaneuh, for the suggestion!

@localheinz localheinz added the bug label Jan 16, 2018
@localheinz localheinz self-assigned this Jan 16, 2018
@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       39     39           
=======================================
  Files             6      6           
  Lines           130    130           
=======================================
  Hits            130    130
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 100% <100%> (ø) 13 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45da47...fe17894. Read the comment docs.

@soullivaneuh
Copy link

LGTM

@localheinz localheinz merged commit aea2b72 into master Jan 16, 2018
@localheinz localheinz deleted the fix/no-scripts branch January 16, 2018 10:12
@localheinz
Copy link
Member Author

Thank you, @soullivaneuh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants