Qdtrack #183
Qdtrack #183
Conversation
|
@mageofboy Is this PR ready for review? |
Sorry for the delayed response. Yes, it is mostly ready, outside of some reformatting |
configs/tracking.conf
Outdated
| @@ -15,7 +15,7 @@ | |||
| --simulator_num_people=200 | |||
| --simulator_num_vehicles=10 | |||
| ######### Other config ######### | |||
| --visualize_tracked_obstacles | |||
| # --visualize_tracked_obstacles | |||
There was a problem hiding this comment.
Can you please revert changes to this config file. I think it's best if this config file uses sort by default because it's a well tested tracker that doesn't have many dependencies.
pylot/perception/flags.py
Outdated
| 'Path to the model') | ||
| flags.DEFINE_string( | ||
| 'qd_track_config_path', | ||
| 'dependencies/qdtrack/configs/qdtrack-frcnn_r50_fpn_12e_bdd100k.py', #FIX |
| flags.DEFINE_string( | ||
| 'qd_track_config_path', | ||
| 'dependencies/qdtrack/configs/qdtrack-frcnn_r50_fpn_12e_bdd100k.py', #FIX | ||
| 'Path to the model') |
There was a problem hiding this comment.
I guess this is the Path to the model configuration.
There was a problem hiding this comment.
Yea, it's the qd track model path but it's currently the path to the bdd model, rather than the waymo model
| git clone https://github.com/mageofboy/qdtrack.git | ||
| git clone https://github.com/open-mmlab/mmdetection.git | ||
| cd mmdetection | ||
| python3 setup.py develop #need to add mmcv |
There was a problem hiding this comment.
How reliable is mmdetection's installation? Did it work out of the box for you?
There was a problem hiding this comment.
unfortunately it is not reliable and installation depends on torch and cuda version
|
Also, can you please make the code style changes necessary to ensure that the CI passes? You can see the suggested changes here: https://github.com/erdos-project/pylot/pull/183/checks?check_run_id=2488080643 |
No description provided.