protos: Update style guide to try and prevent redundant imports #16231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
htuch
reviewed
Apr 30, 2021
phlax
commented
Apr 30, 2021
| @@ -122,8 +122,7 @@ To add an extension config to the API, the steps below should be followed: | |||
| deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"], | |||
| ) | |||
| ``` | |||
| 1. Add to the v3 extension config proto `import "udpa/annotations/migrate.proto";` | |||
| and `import "udpa/annotations/status.proto";` | |||
There was a problem hiding this comment.
im guessing in this case that its ok to just totally remove this
phlax
commented
Apr 30, 2021
| @@ -122,8 +122,7 @@ To add an extension config to the API, the steps below should be followed: | |||
| deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"], | |||
| ) | |||
| ``` | |||
| 1. Add to the v3 extension config proto `import "udpa/annotations/migrate.proto";` | |||
| and `import "udpa/annotations/status.proto";` | |||
| 1. Add to the v3 extension config proto `import "udpa/annotations/status.proto";` | |||
There was a problem hiding this comment.
not sure about this one - this is also added and unused frequently - but im guessing it is needed (in some cases ?) and may relate to some of the docs below ?
There was a problem hiding this comment.
This is needed for the work_in_progress annotation below.
There was a problem hiding this comment.
k - on that basis lets keep - i think the issue is more status not being set than the status proto being included
phlax
changed the title
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 5, 2021
…yproxy#16231) Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…yproxy#16231) Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: protos: Update style guide to try and prevent redundant imports
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #15589
[Optional Deprecated:]
[Optional API Considerations:]