protos: Remove (more) redundant imports #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
it would be really good if we could stop these being added (cf #15589 ) im wondering if any of the protobuf linters might work |
Signed-off-by: Ryan Northey <[email protected]>
htuch
approved these changes
Apr 21, 2021
i very much hope so the main issue i think is that we cant fail on the warnings (there are other unrelated warnings - also this issue can come from upstream protos) - which is why im thinking that using a proto linter is the way forward (hopefully that would catch these issues) |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: protos: Remove (more) redundant imports
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]