dependencies: fix some of the fallout from Wasm merge. #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move use of URLs/sha256 in repositories.bzl to repository_locations.bzl. * Add a check_format rule to validate we don't add URLs outside of repository_locations.bzl in the future. * Extend build graph validator (validate.py) to catch any test deps not covered by "test_only". Exceptions made for Rust/Java/Pip3. Risk level: Low (build only) Testing: Additional validate.py and check_format unit tests. Signed-off-by: Harvey Tuch <[email protected]>
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Harvey Tuch <[email protected]>
mattklein123
approved these changes
Oct 14, 2020
repokitteh-read-only
bot
removed
the
deps
moderation
reviewed
Oct 14, 2020
| @@ -898,7 +898,7 @@ REPOSITORY_LOCATIONS_SPEC = dict( | |||
| "envoy.filters.network.wasm", | |||
| "envoy.stat_sinks.wasm", | |||
| ], | |||
| last_updated = "2020-07-29", | |||
| last_updated = "2020-10-09", | |||
There was a problem hiding this comment.
last_updated = "2018-12-18",
As per https://github.com/antlr/antlr4/releases/tag/4.7.2
There was a problem hiding this comment.
I reckon maybe skip fixing in this PR, I have a followup for release_date that I will post shortly.
There was a problem hiding this comment.
Sounds good but this is a good example of why release_date makes sense. The dep in question was released at the end of 2018 so having reference to last_updated as 2020 could misleed people into thinking the release is current (it isn't as 4.8 has been released however apparently there are Google import conflicts).
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 15, 2020
* master: ci: use multiple stage (envoyproxy#13557) tls: update BoringSSL to 2192bbc8 (4240). (envoyproxy#13567) fix macos v8 build (envoyproxy#13572) Fixed Health Check Fuzz corpus syntax (envoyproxy#13576) ci: Remove shellcheck diff (envoyproxy#13560) ci: Increate brew retry interval (envoyproxy#13565) dependencies: fix some of the fallout from Wasm merge. (envoyproxy#13569) hds: add support for delta updates in specifier (envoyproxy#13067) ci: workaround for actions/runner-images#1811 (envoyproxy#13577) ratelimit: be able to disable x-envoy-ratelimited response header sent (envoyproxy#13270) Update opencensus library (envoyproxy#13549) ci: use azp for api and go-control-plane sync (envoyproxy#13550) docs: Remove/make generic lyft references in docs (envoyproxy#13559) check_format: adding 2 more release note checks (envoyproxy#13444) [Wasm] Add cluster metadata fallback and upstream host metadata (envoyproxy#13477) [fuzz] Added validation for secrets (envoyproxy#13543) Add Platform Specific Feature guidance to PR template (envoyproxy#13547) Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move use of URLs/sha256 in repositories.bzl to
repository_locations.bzl.
Add a check_format rule to validate we don't add URLs outside of
repository_locations.bzl in the future.
Extend build graph validator (validate.py) to catch any test deps
not covered by "test_only". Exceptions made for Rust/Java/Pip3.
Risk level: Low (build only)
Testing: Additional validate.py and check_format unit tests.
Signed-off-by: Harvey Tuch [email protected]