[fuzz] Fixed divide by zero bug #13545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach <[email protected]>
talnordan
reviewed
Oct 13, 2020
source/extensions/filters/http/admission_control/admission_control.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Zach <[email protected]>
htuch
reviewed
Oct 13, 2020
| @@ -52,6 +52,11 @@ double AdmissionControlFilterConfig::aggression() const { | |||
|
|
|||
| double AdmissionControlFilterConfig::successRateThreshold() const { | |||
| const double pct = sr_threshold_ ? sr_threshold_->value() : defaultSuccessRateThreshold; | |||
| // The threshold value should not be 0. Since you cannot add a validation on a widely used Runtime | |||
| // percent value, simply map a 0 percent for the field to the default success rate threshold. | |||
| if (pct == 0) { | |||
There was a problem hiding this comment.
Should we instead throw during config ingest? (not here)
Signed-off-by: Zach <[email protected]>
htuch
reviewed
Oct 16, 2020
Signed-off-by: Zach <[email protected]>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 21, 2020
* master: (22 commits) ci: various improvements (envoyproxy#13660) dns: fix defunct fd bug in apple resolver (envoyproxy#13641) build: support ppc64le with wasm (envoyproxy#13657) [fuzz] Added random load balancer fuzz (envoyproxy#13400) dependencies: compute and check release dates via GitHub API. (envoyproxy#13582) mac ci: try ignoring update failure (envoyproxy#13658) watchdog: Optimize WatchdogImpl::touch in preparation to more frequent petting of the watchdog. (envoyproxy#13103) typos: fix a couple 'enovy' mispellings (envoyproxy#13645) lua: Expose stream info downstreamLocalAddress and downstreamDirectRemoteAddress for Lua filter (envoyproxy#13536) tap: fix upstream streamed transport socket taps (envoyproxy#13638) Revert "delay health checks until transport socket secrets are ready. (envoyproxy#13516)" (envoyproxy#13639) Watchdog: use abort action as a default if killing is enabled. (envoyproxy#13523) [fuzz] Fixed divide by zero bug (envoyproxy#13545) wasm: flip the meaning of the "repository" in envoy_wasm_cc_binary(). (envoyproxy#13621) fix: record recovered local address (envoyproxy#13581) docs: fix incorrect compressor filter doc (envoyproxy#13611) docs: clean up docs for azp migration (envoyproxy#13558) wasm: fix building Wasm example. (envoyproxy#13619) test: Refactor flood tests into a separate test file (envoyproxy#13556) wasm: re-enable tests with precompiled modules. (envoyproxy#13583) ... Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zach Reyes [email protected]
Commit Message: Fixed divide by zero bug in admission control filter for HTTP.
Additional Description: Fixes issues: https://oss-fuzz.com/testcase-detail/5914972389113856
Risk Level: Low
Testing: Added regression test
Docs Changes: N/A
Release Notes: N/A