grpc-json: preserve request method in x-envoy-original-method header #11126
Conversation
…nscoder Signed-off-by: Phillip Huang <[email protected]>
include/envoy/http/header_map.h
Outdated
| @@ -293,6 +293,7 @@ class HeaderEntry { | |||
| HEADER_FUNC(EnvoyRetryGrpcOn) \ | |||
| HEADER_FUNC(EnvoyRetriableStatusCodes) \ | |||
| HEADER_FUNC(EnvoyRetriableHeaderNames) \ | |||
| HEADER_FUNC(EnvoyOriginalMethod) \ | |||
There was a problem hiding this comment.
Drive by: please don't add this to the O(1) header map, as it only needs to be set.
Also, this change will need documentation and release notes. Thank you!
There was a problem hiding this comment.
Thanks for pointing this out. Could you point out where you would like to see the documentation? I could not find any prior mention of headers in https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/grpc_json_transcoder_filter. Should I create a section there anyway?
There was a problem hiding this comment.
Yeah I think documenting this within the filter config docs would be fine for now. Thank you!
…ase notes Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
JavaScriptBach
changed the title
Signed-off-by: Phillip Huang <[email protected]>
| @@ -87,6 +87,15 @@ can be send by the gRPC server in the server streaming case. | |||
| In this case, HTTP response header `Content-Type` will use the `content-type` from the first | |||
| `google.api.HttpBody <https://github.com/googleapis/googleapis/blob/master/google/api/httpbody.proto>`. | |||
|
|
|||
| Metadata | |||
There was a problem hiding this comment.
let's call this header. Metadata is confusing with dynamic metadata
There was a problem hiding this comment.
Done. Can you review again?
Signed-off-by: Phillip Huang <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
Can you merge master and resolve conflicts? Then we can merge this. Thank you! |
stale
bot
removed
the
stale
Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
Done. Thank you! |
…nvoyproxy#11126) Commit Message: grpc-json: preserve http request method in `x-envoy-original-method` header so that applications have access to it. Additional Description: The grpc-json transcoder currently forwards HTTP path to applications via "x-envoy-original-path" header. We would find it useful if it also forwarded the HTTP method. Risk Level: Low Testing: Updated grpc-json-transcoder unit tests Docs Changes: Added docs Release Notes: Added release notes Signed-off-by: Phillip Huang <[email protected]> Signed-off-by: Auni Ahsan <[email protected]>
…nvoyproxy#11126) Commit Message: grpc-json: preserve http request method in `x-envoy-original-method` header so that applications have access to it. Additional Description: The grpc-json transcoder currently forwards HTTP path to applications via "x-envoy-original-path" header. We would find it useful if it also forwarded the HTTP method. Risk Level: Low Testing: Updated grpc-json-transcoder unit tests Docs Changes: Added docs Release Notes: Added release notes Signed-off-by: Phillip Huang <[email protected]> Signed-off-by: yashwant121 <[email protected]>
Commit Message: grpc-json: preserve http request method in
x-envoy-original-methodheader so that applications have access to it.Additional Description: The grpc-json transcoder currently forwards HTTP path to applications via "x-envoy-original-path" header. We would find it useful if it also forwarded the HTTP method.
Risk Level: Low
Testing: Updated grpc-json-transcoder unit tests
Docs Changes: Added docs
Release Notes: Added release notes