Skip to content

Commit

Permalink
wasm: re-enable tests with precompiled modules. (#13583)
Browse files Browse the repository at this point in the history
Fixes #12335.

Signed-off-by: Piotr Sikora <[email protected]>
  • Loading branch information
PiotrSikora authored Oct 17, 2020
1 parent 6287f17 commit 3588759
Showing 1 changed file with 0 additions and 35 deletions.
35 changes: 0 additions & 35 deletions test/extensions/common/wasm/wasm_vm_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,6 @@ TEST_P(WasmVmTest, V8BadCode) {
}

TEST_P(WasmVmTest, V8Code) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);
EXPECT_TRUE(wasm_vm->runtime() == "v8");
Expand All @@ -171,13 +164,6 @@ TEST_P(WasmVmTest, V8Code) {
}

TEST_P(WasmVmTest, V8BadHostFunctions) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand All @@ -199,13 +185,6 @@ TEST_P(WasmVmTest, V8BadHostFunctions) {
}

TEST_P(WasmVmTest, V8BadModuleFunctions) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down Expand Up @@ -234,13 +213,6 @@ TEST_P(WasmVmTest, V8BadModuleFunctions) {
}

TEST_P(WasmVmTest, V8FunctionCalls) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down Expand Up @@ -279,13 +251,6 @@ TEST_P(WasmVmTest, V8FunctionCalls) {
}

TEST_P(WasmVmTest, V8Memory) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down

0 comments on commit 3588759

Please sign in to comment.