No error/warning on failed snapshot deletion #10676 #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.15 #10805 +/- ##
============================================
+ Coverage 84.50% 84.51% +0.01%
- Complexity 19621 19626 +5
============================================
Files 2608 2608
Lines 68272 68283 +11
Branches 5435 5434 -1
============================================
+ Hits 57691 57709 +18
+ Misses 7944 7937 -7
Partials 2637 2637 ☔ View full report in Codecov by Sentry. |
rymsha
requested changes
Dec 11, 2024
modules/core/core-api/src/main/java/com/enonic/xp/node/DeleteSnapshotsResult.java
Show resolved
Hide resolved
modules/core/core-api/src/main/java/com/enonic/xp/node/DeleteSnapshotsResult.java
Outdated
Show resolved
Hide resolved
anatol-sialitski
force-pushed
the
issue-10676-v7.15
branch
from
e45a999 to
001465b
Compare
rymsha
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.