This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Add a --lib option to include .js files from a package lib directory. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of ender users would expect that using Ender's require would work just like node's require. Moreover many packages distributed with npm have a lib directory and a main javascript file that just requires code from the lib directory. Previous to this commit, `ender build` only included the package's main file, and if this main file tried to require a file from its lib directory, doing so would fail. This patch adds a --lib option to the `build` and `add` commands to tell ender to include the .js files from the directory defined on a module's package.json file. The client-side code for allowing relative requires is implemented at ender-js/ender-js#13
This was referenced Mar 9, 2012
|
Since we're focusing on the 1.0-wip branch I'm going to close this unfortunately. I don't mind where you're heading with this but I think it can be rolled together in #131 and #124 in a more integrated way. Feel free to open another issue or PR on this against the 1.0-wip branch but again, it might be best to discuss larger changes in an issue first so we can iron out the details before diving in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of ender users would expect that using Ender's require would work
just like node's require. Moreover many packages distributed with npm
have a lib directory and a main javascript file that just requires
code from the lib directory.
Previous to this commit,
ender buildonly included the package'smain file, and if this main file tried to require a file from its
lib directory, doing so would fail.
This patch adds a --lib option to the
buildandaddcommands totell ender to include the .js files from the directory defined on
a module's package.json file.
The client-side code for allowing relative requires is implemented at
ender-js/ender-js#13