Replace dict
by Mapping
on HTTPException.headers
#2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See also: fastapi/fastapi#12786
HTTP Headers cannot be represented by a
dict
, as they can have duplicate entries. Example:Set-Cookie
.As such type of
starlette.exceptions.HTTPException
'sheaders
field should betyping.Mapping
instead ofdict
, just likestarlette.responses.Response
'sheaders
field:starlette/starlette/responses.py
Lines 27 to 38 in c2e3a39
Checklist