Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testclient): exclude query sting from raw_path #2716

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

raptium
Copy link
Contributor

@raptium raptium commented Oct 4, 2024

Summary

As we discussed in #2692, this commit updates the testclient so that query string is excluded from raw_path
for both HTTP and WebSocket.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex changed the title fix(testclient): exclude query sting from raw_path before passing to app fix(testclient): exclude query sting from raw_path Nov 18, 2024
@Kludex Kludex merged commit 9dc9d2e into encode:master Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch Between ASGI Specification and httpx's raw_path Definition in TestClient
2 participants