-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema generation doc & add deprecation notice #8453 #8773
Conversation
Hi @tfranzel thank for this. I think it's the way to go yes. Ultimately it's @tomchristie's call so we'll defer to him here. 🎁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful. 💛
Co-authored-by: Tom Christie <[email protected]>
Co-authored-by: Tom Christie <[email protected]>
Co-authored-by: Tom Christie <[email protected]>
@tfranzel - Since this is your PR, I've sent you an invite to the @encode/django-rest-framework team. Please don't feel obligated to accept. If you do choose to, then you'll have permissions to merge/approve this (and other) PRs. If you'd prefer not to, then one of the other maintainers will merge this pull request sometime soon. |
thank you @tomchristie for the invitation. happy to join ❤️ |
BTW, I am still willing to merge small edge case fixes for built in openapi support |
I think when this is deployed we could likely point back here (or the discussion maybe as better) and close related PRs and Issues. 🤔 (Bottom line is folks are better off moving to drf-spectacular than waiting for a not as good improvement in the in-built introspection.) I'd suggest the CoreAPI generation could simply be removed at this point. I guess the OpenAPI generation should still be moved out (with tests and everything) to a package so folks can swap an import/setting/etc to use if they need. I'd guess that all that should remain in |
The `django-rest-framework`'s built-in support for OpenAPI schema generation has been deprecated (encode/django-rest-framework#8773). `drf-spectacular` is the recommended alternative, but CourtListener's schema has always been experimental. Moreover the current integration is crashing and has other bugs that prevent its effective use. Outright removal, rather than replacement is the best way forward. Fixes: freelawproject#3653, freelawproject#1616
As discussed in #8453, this PR re-arranges some aspects of the schema documentation.
schema.md
: add deprecation noticedocumenting-your-api.md
: add deprecation noticedocumenting-your-api.md
: push deprecated approach below the recommended onedocumenting-your-api.md
: adapt intro textdocumenting-your-api.md
: recommend drf-spectaculardocumenting-your-api.md
: make clear that drf-yasg is OpenAPI 2