Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent serializer DictField as an Object in schema #5765

Closed
wants to merge 1 commit into from
Closed

Represent serializer DictField as an Object in schema #5765

wants to merge 1 commit into from

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Jan 23, 2018

DictFields were incorrectly being output as String in the schema.
This pull request outputs an Object instead and adds a unit test.

DictFields were incorrectly being output as String in the schema.
This pull request outputs an Object instead and adds a unit test.
@jlaine
Copy link
Contributor Author

jlaine commented Jan 24, 2018

NOTE : HStoreField also benefits from this change as it inherits DictField. JSONField on the other hand does not.

@carltongibson carltongibson added this to the 3.8 Release milestone Jan 24, 2018
Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass: looks good. (In general, yes we need to add these exception cases 👍)

@carltongibson
Copy link
Collaborator

Closed in a8d129b

@jlaine jlaine deleted the dict-field-schema branch April 9, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants