New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Location header is strictly a 'str', not subclass. #5544

Merged

tomchristie merged 1 commit into master from strict-str-header

Oct 30, 2017

Member

tomchristie commented Oct 30, 2017

Closes #5541


          Ensure Location header is strictly a 'str', not subclass. Closes #5541

32e4545

tomchristie added the Bug label

tomchristie added this to the 3.7.2 milestone

tomchristie merged commit 2b6245d into master

tomchristie deleted the strict-str-header branch

October 30, 2017 13:08

canni reviewed

View reviewed changes

rest_framework/mixins.py

@@ @@ -27,7 +27,7 @@ def perform_create(self, serializer): @@
                   def get_success_headers(self, data):
                       try:
-                          return {'Location': data[api_settings.URL_FIELD_NAME]}
+                          return {'Location': str(data[api_settings.URL_FIELD_NAME])}

canni Oct 30, 2017

why not six.text_type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug