include date and date-time format in coreapi schema generation #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This seems reasonable yes.
@tomchristie Can I just ask you to comment on the format magic string values here? They seem reasonable but is there a canonical list of accepted values?
|
The format is from OpenAPI v2: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types Maybe also relevant; python-coreschema has |
|
@zbyte64 Good follow-up. Exactly right. Give the Thanks for the input! |
carltongibson
approved these changes
Oct 20, 2017
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the proper format when translating serializers.DateField & DateTimeField to coreapi/coreschema
Helps down the line with swagger:
marcgibbons/django-rest-swagger#703