This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
WIP: make this crate a library that includes a binary #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to allow other code (like a client/server) to use `enarx_keepldr` as a library to build keeps, rather than having to `exec()` the `enarx-keepldr` binary. This commit refactors the crate to be a library - with an included `enarx-keepldr` binary, built from `src/bin/enarx-keepldr.rs`. This is a work-in-progress - the documentation on the `enarx_keepldr` library is incomplete. There are some half-assed placeholder doc comments here and there, but in order to get this to compile (so I can make sure everything still works as expected) I've temporarily turned on the #[allow(missing_docs)] directive. Signed-off-by: Will Woods <[email protected]>
wgwoods
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow other code (like a client/server) to use
enarx_keepldras a library to build keeps, rather than having toexec()theenarx-keepldrbinary.This commit refactors the crate to be a library - with an included
enarx-keepldrbinary, built fromsrc/bin/enarx-keepldr.rs.This is a work-in-progress - the documentation on the
enarx_keepldrlibrary is incomplete. There are some half-assed placeholder doc
comments here and there, but in order to get this to compile (so I can
make sure everything still works as expected) I've temporarily turned on
the #[allow(missing_docs)] directive.
Signed-off-by: Will Woods [email protected]