Feature/cycle event limit #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- panic in the plain rust cycle event iter - set a lua callback error in the scripted cycle event iter
- to ease constructing it and to add a constant for the event limit default - to avoid passing "None" for seeds all the time
|
I've changed things to
In the last commit I also changed the default argument handling in Cycle with two new "with_" functions. Unfortunately there are no default argument values in Rust functions and various ways to handle this. I like this one and use it as a pattern throughout this crate. If you dislike it or think it is off topic, I can remove the last commit again. |
emuell
approved these changes
Jun 14, 2024
|
I like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #9
Cycle::generatenow returns aResultthat fails if the output exceeds the limit defined for the Cycle (currently0x1000).I changed the files that used
Cycle::generateto avoid errors (they just output no events in case of a fail), but I suppose the error should be propagated up to the user. I could look into this but maybe it's best if you implement the rest of this however you want.