-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cycle mapping #20
Conversation
These functions were moved into Value on my branch. The issue I see with the implementation here is that the string returned is not the actual parsed literal as this comment suggests, instead, it is a string derived from the value
So I think this should be copied to the event from the Single's string field at this point which is the actual string literal that was in the input (parsed here). I'd rather implement this on my branch and merge that first. |
From what I can see and what I've tested, this is the raw string from the Pest Pair<> and not a serialized value: Line 31 in 8f4e78a
|
Edit, nevermind. I got confused by seeing you've added the Pitch to string but I can see now that's only for tests. |
I would rather merge my branch first and this one later but it's fine either way. |
Now that the feature branch is merged, should I resolve the conflicts here? |
No, thanks. I'm on it already. |
… to report errors without a Callback instance
…dynamically to notes
8f4e78a
to
bd90733
Compare
See #13
This allows mapping identifiers and other existing note values in cycles to custom note values via a static map (a table, in Lua):
... and via a function callback:
Context in map functions contains global info such as transport timing and also maintains step counters which are running individually for each channel in the cycle.
Only single notes can be used as mapped value. Chords and thus also stuff like
note('c4')
values are not yet supported. This will be done in a separate PR.As soon as we allow chords in mappings, we can also add some helper mappings and function to ease mapping scales and stuff.
@unlessgames We likely do conflict here: I've added a new "string" property to Event, which is used as key for the mapping.
Decide you if we merge this PR or yours first.