Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

syntax detection based on scope, not grammar #43

Merged
merged 1 commit into from
Mar 3, 2014
Merged

syntax detection based on scope, not grammar #43

merged 1 commit into from
Mar 3, 2014

Conversation

lucas-clemente
Copy link
Contributor

this allows emmet to work in html/css based languages like hanbdlebars or erb.

this allows emmet to work in html/css based languages
like hanbdlebars or erb.
@gjtorikian gjtorikian merged commit 3f206f1 into emmetio:master Mar 3, 2014
@gjtorikian
Copy link
Contributor

Added some tests, but otherwise, thanks! Pushing a new release.

@epogue
Copy link

epogue commented Mar 3, 2014

Awesome! Thanks @lucas-clemente!

@lucas-clemente lucas-clemente deleted the scopes branch March 3, 2014 14:51
@davewasmer
Copy link

As far as I can tell, this has regressed, but it's pretty confusing. Looking through the Github history, I get two different pictures depending on which commit I use as the starting point (perhaps there was some kind of rebase or other history-rewriting change and this is how Github renders it?):

The history leading up to the change introduced by this PR:
https://github.com/emmetio/emmet-atom/commits/3f206f1313bc166655f7b4acb4934b8cc0c7a0da/lib/editor-proxy.coffee

image

The history of lib/editor-proxy.coffee (the file modified by this PR), viewed with master as the starting point:
https://github.com/emmetio/emmet-atom/commits/master/lib/editor-proxy.coffee

image

Not sure what happened, but long story short, this isn't working once again.

@davewasmer
Copy link

Happy to try submitting a PR that combines this fix with the current state (which seems to account for JSX), but wanted to be sure first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants