Added Elisp version of the kata #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecop
reviewed
Oct 7, 2024
elisp/gilded-rose-test.el
Outdated
There was a problem hiding this comment.
Please make this test similar to other sample tests, e.g. https://github.com/emilybache/GildedRose-Refactoring-Kata/blob/main/clojure/test/gilded/core_test.clj
i.e. check that the name of "foo" is not "fixme".
elisp/gilded-rose.el
Outdated
|
|
||
| (defun update-quality (item) | ||
| "Update the quality of the ITEM according to the Gilded Rose rules." | ||
| (let ((quality (item-quality item)) |
There was a problem hiding this comment.
the lets are already a simplification/improvement of the original code. Is it possible to access the value from the struct each time?
There was a problem hiding this comment.
Thank you. This was the simplest way I could represent the problem with the elisp I know. I'll have a look at getting the value from the struct each time
- Initial test modified to be similar to Clojure version - update-quality modified to read from make-item directly. Helper methods removed
|
For future there is no need to create a new pr. New commits appear in the pr automatically. Continues in #574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ ME BEFORE SUBMITTING A PR
Please do not submit a PR with your solution to the Gilded Rose Kata. This repo is intended to be used as a starting point for the kata.
Please provide your PR description below this line
Added elisp version of the kata. PR contains source code, test file with one failing test and readme file