Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval tests starting points for PHP and TS/Jest. #498

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

codecop
Copy link
Collaborator

@codecop codecop commented Nov 29, 2023

READ ME BEFORE SUBMITTING A PR

Please do not submit a PR with your solution to the Gilded Rose Kata. This repo is intended to be used as a starting point for the kata.

  • I acknowledge that this PR is not a solution to the Gilded Rose Kata, but an improvement to the template.

Please provide your PR description below this line

Adds Approval tests starting points for PHP and TS/Jest.

@emilybache emilybache merged commit 2e30c56 into emilybache:main Nov 30, 2023
1 check passed
@emilybache
Copy link
Owner

I was debating with myself whether I wanted two variants of approval test style here. I landed with that it was actually helpful. Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants