Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Add Inspector Update #3739

Merged
merged 6 commits into from
Dec 19, 2018
Merged

Add Inspector Update #3739

merged 6 commits into from
Dec 19, 2018

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Dec 18, 2018 •
edited
Loading

Adding update about Ember Inspector to the times post.

chrisrng
chrisrng reviewed Dec 18, 2018
View reviewed changes
source/blog/2018-12-21-the-ember-times-issue-78.md Outdated
@@ -12,7 +12,27 @@ responsive: true

---

## [SECTION TITLE](#section-url)
## [What's New in Ember Inspector](#section-url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually add an emoji at the end of the title :)

Alonski
Alonski previously requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@Alonski Alonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you should probably add yourself to the authors prop at the top and bottom of the post :)

Looks great! Awesome work!

source/blog/2018-12-21-the-ember-times-issue-78.md Outdated Show resolved Hide resolved
source/blog/2018-12-21-the-ember-times-issue-78.md Outdated Show resolved Hide resolved
@RobbieTheWagner
Copy link
Member Author

@Alonski @amyrlam I think I fixed all the things you flagged. Mind taking another look?

amyrlam
amyrlam approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this writeup is 💯, thank you!

@amyrlam amyrlam merged commit 1af5d04 into emberjs:blog/embertimes-78 Dec 19, 2018
@RobbieTheWagner RobbieTheWagner deleted the ember-inspector-new branch December 19, 2018 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisrng chrisrng chrisrng left review comments

@amyrlam amyrlam amyrlam approved these changes

@Alonski Alonski Alonski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobbieTheWagner @Alonski @amyrlam @chrisrng