[DOC RELEASE] Ember 1.13 Component Lifecycle Events API Docs #13250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
changed the title
|
This documents the evented versions of these, can we also document the methods themselves (which I think should be the primary way to use these hooks)? |
|
@rwjblue Sure. Done! |
|
Looks like some JSCS errors with trailing white space are failing the build here. Can you take a look? |
|
@rwjblue Fixed. |
Add method docs Fix jscs error
Gaurav0
force-pushed
the
component_event_docs
branch
from
554b873 to
4adef52
Compare
|
I'm a bit iffy of so many |
|
@locks - The screenshot says "view", but the diff uses "component" (the screenshot wasn't updated after the last round of changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13244