Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in <DocsViewer::XNav> #1556

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fixed typo in <DocsViewer::XNav> #1556

merged 1 commit into from
Mar 6, 2024

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Mar 6, 2024 •
edited
Loading

Description

On mobile, the navigation shows the class names because the <button> tag hadn't been closed correctly.

@ijlee2 ijlee2 added the bug label Mar 6, 2024
@ijlee2 ijlee2 requested a review from RobbieTheWagner March 6, 2024 14:37
@ijlee2 ijlee2 marked this pull request as ready for review March 6, 2024 14:37
IgnaceMaes
IgnaceMaes approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

I would've expected CI to catch this, but seems like it didn't 🤔

@IgnaceMaes IgnaceMaes merged commit c9a004e into ember-learn:master Mar 6, 2024
15 checks passed
@ijlee2 ijlee2 mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnaceMaes IgnaceMaes IgnaceMaes approved these changes

@SergeAstapov SergeAstapov SergeAstapov approved these changes

@RobbieTheWagner RobbieTheWagner Awaiting requested review from RobbieTheWagner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijlee2 @SergeAstapov @IgnaceMaes