Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(config): remove all usage of ember-get-config #1143

Merged
merged 1 commit into from
Feb 15, 2022
Merged

chore(config): remove all usage of ember-get-config #1143

merged 1 commit into from
Feb 15, 2022

Conversation

anehx
Copy link
Contributor

@anehx anehx commented Feb 15, 2022

Follow up of our discussion on #1137

@anehx anehx mentioned this pull request Feb 15, 2022
Merged
@anehx anehx force-pushed the remove-ember-get-config branch 4 times, most recently from a5c7c0c to 8a05dbe Compare February 15, 2022 15:39
@anehx anehx force-pushed the remove-ember-get-config branch from 8a05dbe to 5aa4944 Compare February 15, 2022 15:51
RobbieTheWagner
RobbieTheWagner approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@RobbieTheWagner RobbieTheWagner merged commit 667701d into ember-learn:master Feb 15, 2022
@ijlee2 ijlee2 mentioned this pull request Jun 16, 2022
Merged
@anehx anehx deleted the remove-ember-get-config branch July 30, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@SergeAstapov SergeAstapov SergeAstapov approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anehx @SergeAstapov @RobbieTheWagner