update docs-logo component #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelcobain
commented
Feb 9, 2022
| @@ -35,8 +35,8 @@ export default class DocsLogo extends Component { | |||
| @equal('logo', 'ember-data') | |||
| showEmberData; | |||
|
|
|||
| didReceiveAttrs() { | |||
| super.didReceiveAttrs(...arguments); | |||
| constructor() { | |||
There was a problem hiding this comment.
@rwwagner90 Just realized that this won't throw if the user changes the argument to an invalid logo. Only throws on first render.
I think the chances of someone doing that are pretty slim though. But if you think it's worth it, I can have this assertion on a {{did-update render modifier.
There was a problem hiding this comment.
@miguelcobain no, I think just throwing initially is fine
RobbieTheWagner
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.