Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ember-data related syntax #1116

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

miguelcobain
Copy link
Collaborator

Updates the ember-data and mirage related files syntax.
Consider this part of the effort to update this addon. :)

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

addon/adapters/class.js Show resolved Hide resolved
addon/models/component.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@SergeAstapov
Copy link
Collaborator

@rwwagner90 only minor points, so we can land this one

@miguelcobain
Copy link
Collaborator Author

miguelcobain commented Feb 8, 2022

Replaced @attr() with @attr.

@RobbieTheWagner
Copy link
Member

Thanks @miguelcobain!

@RobbieTheWagner RobbieTheWagner merged commit 0df6801 into ember-learn:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants