Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix build stability #410

Merged
merged 1 commit into from
Jun 1, 2017
Merged

[BUGFIX] fix build stability #410

merged 1 commit into from
Jun 1, 2017

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Jun 1, 2017

This prevents fastboot from constantly writing its package.json if it has not changed.

  • tests

@kratiahuja
Copy link
Contributor

LGTM. I think there are existing tests around the package.json. What other tests did you have in mind?

@stefanpenner
Copy link
Contributor Author

stefanpenner commented Jun 1, 2017

I think there are existing tests around the package.json

Unit tests, the existing ones are too high level to add proper coverage (and also quite slow and brittle)

Working one them now.

@stefanpenner stefanpenner force-pushed the fix-build-stability branch 2 times, most recently from 6abcb85 to 9a3f478 Compare June 1, 2017 05:59
This prevents fastboot from constantly writing its package.json if it has not changed.
@stefanpenner stefanpenner force-pushed the fix-build-stability branch from 9a3f478 to 08b73e0 Compare June 1, 2017 06:00
@stefanpenner
Copy link
Contributor Author

stefanpenner commented Jun 1, 2017

@kratiahuja I have added tests targeting the build and build stability. (If you are good with it, feel free to merge and release)


Would likely recommend we transition more and more of the tests to more targeted tests like this. Rather then the end to end tests we have now. I feel we have better confidence with the tests, easier to pin-point issues, easier to add additional scenarios etc, then the existing approach.

@simonihmig
Copy link
Contributor

simonihmig commented Jun 1, 2017

Tried this also, and can confirm this works perfectly! 👍

For the record: this also fixes the issue that CSS hot reloading was not working correctly, the browser would always do a full reload even if just some CSS/Sass files changed.

@stefanpenner stefanpenner merged commit 22a446d into master Jun 1, 2017
@stefanpenner
Copy link
Contributor Author

I'll release rc2 when I get to work

@stefanpenner stefanpenner deleted the fix-build-stability branch June 1, 2017 15:37
@stefanpenner
Copy link
Contributor Author

stefanpenner commented Jun 1, 2017

released as v1.0.0-rc.2 🎉 -> https://twitter.com/stefanpenner/status/870303500160212992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants