-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] fix build stability #410
Conversation
LGTM. I think there are existing tests around the package.json. What other tests did you have in mind? |
Unit tests, the existing ones are too high level to add proper coverage (and also quite slow and brittle) Working one them now. |
6abcb85
to
9a3f478
Compare
This prevents fastboot from constantly writing its package.json if it has not changed.
9a3f478
to
08b73e0
Compare
@kratiahuja I have added tests targeting the build and build stability. (If you are good with it, feel free to merge and release) Would likely recommend we transition more and more of the tests to more targeted tests like this. Rather then the end to end tests we have now. I feel we have better confidence with the tests, easier to pin-point issues, easier to add additional scenarios etc, then the existing approach. |
Tried this also, and can confirm this works perfectly! 👍 For the record: this also fixes the issue that CSS hot reloading was not working correctly, the browser would always do a full reload even if just some CSS/Sass files changed. |
I'll release rc2 when I get to work |
released as v1.0.0-rc.2 🎉 -> https://twitter.com/stefanpenner/status/870303500160212992 |
This prevents fastboot from constantly writing its package.json if it has not changed.