Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatic import of ember-qunit and qunit in ember-mocha projects #699

Conversation

ndekeister-us
Copy link

@ndekeister-us ndekeister-us commented Jul 8, 2021

Should fix #666

It was trying to auto-import ember-qunit and qunit in projects using ember-mocha, leading to build errors


Tested

@ndekeister-us
Copy link
Author

@step2yeung @thoov may i ask for your review 🙏

@kevinansfield
Copy link

I've just re-tested the PR with Ghost's current main and can confirm it fixes our broken build we started seeing with 6.1.0

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2021

Merged master to get a CI build kicked off...

@ndekeister-us
Copy link
Author

@rwjblue they are failing because of this error

liquid-fire/templates/components/liquid-outlet.hbs: Assertion Failed: Named outlets were removed in Ember 4.0. See https://deprecations.emberjs.com/v3.x#toc_route-render-template for guidance on alternative APIs for named outlet use cases. ('liquid-fire/templates/components/liquid-outlet.hbs' @ L18:C10) 

liquid-fire (which is used by ember-cli-addon-docs) use named outlets in this component

But

I made a PR in this repo -> #720 to, at least, update ember-cli-addon-docs to a recent version but i'm not sure of what we should do as ember-cli-addon-docs is now in maintenance mode so even if we fix the "issue" in liquid-fire repo, we may have new issues with future Ember versions

@ndekeister-us
Copy link
Author

@rwjblue made PR #720 to fix ember-beta/canary scenarios (mainly by updating https://github.com/ember-learn/ember-cli-addon-docs/)

@ndekeister-us ndekeister-us force-pushed the fix/auto-import_qunit_in_mocha_projects branch from 00814cb to e21ae27 Compare December 24, 2021 14:35
@ndekeister-us ndekeister-us force-pushed the fix/auto-import_qunit_in_mocha_projects branch from e21ae27 to 71dbb4e Compare December 24, 2021 14:37
@ndekeister-us
Copy link
Author

ndekeister-us commented Dec 24, 2021

Rebased with master, tested again on

Locally

  • test:ember
  • ember try:one ember-canary ✅ (didn't tested the other, but if canary pass it should be fine)

@maxfierke
Copy link

@ndekeister-us @rwjblue Is there anything blocking merge/release of this? This seems to be necessary to get ember-mocha apps on the latest ember-exam & Ember 3.28 and beyond.

(sorry for the ping)

@ndekeister-us
Copy link
Author

Maybe ping @Turbo87 (same, sorry for the ping)

@ndekeister-us
Copy link
Author

Closing as I guess it will never be merged (see https://rfcs.emberjs.com/id/0858-deprecate-ember-mocha/ ; emberjs/ember.js#20402)

@ndekeister-us ndekeister-us deleted the fix/auto-import_qunit_in_mocha_projects branch May 5, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App won't build with ember-exam 6.1.0 and ember-mocha
4 participants