-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: automatic import of ember-qunit and qunit in ember-mocha projects #699
fix: automatic import of ember-qunit and qunit in ember-mocha projects #699
Conversation
@step2yeung @thoov may i ask for your review 🙏 |
I've just re-tested the PR with Ghost's current |
Merged master to get a CI build kicked off... |
@rwjblue they are failing because of this error
liquid-fire (which is used by ember-cli-addon-docs) use named outlets in this component But
I made a PR in this repo -> #720 to, at least, update ember-cli-addon-docs to a recent version but i'm not sure of what we should do as ember-cli-addon-docs is now in maintenance mode so even if we fix the "issue" in liquid-fire repo, we may have new issues with future Ember versions |
@rwjblue made PR #720 to fix ember-beta/canary scenarios (mainly by updating https://github.com/ember-learn/ember-cli-addon-docs/) |
00814cb
to
e21ae27
Compare
e21ae27
to
71dbb4e
Compare
Rebased with master, tested again on
Locally
|
@ndekeister-us @rwjblue Is there anything blocking merge/release of this? This seems to be necessary to get ember-mocha apps on the latest ember-exam & Ember 3.28 and beyond. (sorry for the ping) |
Maybe ping @Turbo87 (same, sorry for the ping) |
Closing as I guess it will never be merged (see https://rfcs.emberjs.com/id/0858-deprecate-ember-mocha/ ; emberjs/ember.js#20402) |
Should fix #666
It was trying to auto-import
ember-qunit
andqunit
in projects usingember-mocha
, leading to build errorsTested
[email protected]
, see test: fix for ember-exam #699 and ember-cli-mirage #2209 ndekeister-us/Admin#1c6dec4ba829975297d00f0c3fe438f052b1bd257
-> it will now build the project and run tests (there is maybe another issue with ember-cli-mirage, see fix: ember-qunit dependencies check miragejs/ember-cli-mirage#2209, but i'm not able to reproduce it anymore so maybe was linked to something wrong in my environment)[email protected]
[email protected]