Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock and goroutine leak in Stream() #9

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Deadlock and goroutine leak in Stream() #9

merged 1 commit into from
Jan 13, 2022

Conversation

embano1
Copy link
Owner

@embano1 embano1 commented Jan 10, 2022

#7

Signed-off-by: Michael Gasch [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #9 (5a8fa66) into main (c4ae14e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   91.16%   91.11%   -0.05%     
==========================================
  Files           4        4              
  Lines         181      180       -1     
==========================================
- Hits          165      164       -1     
  Misses         10       10              
  Partials        6        6              
Impacted Files Coverage Δ
stream.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ae14e...5a8fa66. Read the comment docs.

@embano1 embano1 marked this pull request as draft January 12, 2022 09:13
Closes: #7
Signed-off-by: Michael Gasch <[email protected]>
@embano1 embano1 marked this pull request as ready for review January 13, 2022 19:06
@embano1 embano1 merged commit b2818a9 into main Jan 13, 2022
@embano1 embano1 deleted the issue-7 branch January 13, 2022 19:12
@embano1 embano1 changed the title Remove ErrSlowReader implementation in stream Deadlock and goroutine leak in Stream() Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants