Added exceptions for empty or bad patterns, fixed tests, updated

.gitignore file

.gitignore

@@ -10,4 +10,6 @@ rdoc/
 .DS_Store/
 .DS_Store
 lib/.DS_Store
-Gemfile.lock
+Gemfile.lock
+.ruby-gemset
+.ruby-version

lib/protokoll/counter.rb

@@ -19,7 +19,7 @@ def self.next(object, options)
     private
 
     def self.outdated?(record, options)
-      Time.now.strftime(update_event(options)).to_i > record.updated_at.strftime(update_event(options)).to_i
+      Time.now.utc.strftime(update_event(options)).to_i > record.updated_at.strftime(update_event(options)).to_i
     end
 
     def self.update_event(options)

lib/protokoll/protokoll.rb

@@ -17,6 +17,8 @@ def protokoll(column, _options = {})
                   :start         => 0 }
 
       options.merge!(_options)
+      raise ArgumentError.new("pattern can't be nil!") if options[:pattern].nil?
+      raise ArgumentError.new("pattern requires at least one counter symbol #{options[:number_symbol]}") unless pattern_includes_symbols?(options)
 
       # Defining custom method
       send :define_method, "reserve_#{options[:column]}!".to_sym do
@@ -30,6 +32,12 @@ def protokoll(column, _options = {})
         end
       end
     end
+
+    private
+
+    def pattern_includes_symbols?(options)
+      options[:pattern].count(options[:number_symbol]) > 0
+    end
   end
 
 end

test/protokoll_test.rb

@@ -388,6 +388,24 @@ class Protocol < ActiveRecord::Base
     assert_equal "2011092601", protocol3.number
   end
 
+  test "rejects empty patterns" do
+
+    assert_raise ArgumentError do
+      class Protocol < ActiveRecord::Base
+        protokoll :number, :pattern => nil
+      end
+    end
+  end
+
+  test "rejects invalid patterns" do
+
+    assert_raise ArgumentError do
+      class Protocol < ActiveRecord::Base
+        protokoll :number, :pattern => "%ydodgyPattern"
+      end
+    end
+  end
+
 end