Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

Skip definitions for well known types. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip definitions for well known types. #7

wants to merge 1 commit into from

Conversation

RyogaK
Copy link
Contributor

@RyogaK RyogaK commented Aug 2, 2018

It seems that definitions of swagger.json for well known types are not necessary because well known types are already mapped to swagger's primitive types.

Could you confirm this?

@elliots
Copy link
Owner

elliots commented Aug 2, 2018

Uhhm. I don't actually have this project set up to run at the moment, will this commit cause problems, or should i just accept it?

@RyogaK
Copy link
Contributor Author

RyogaK commented Aug 3, 2018

@elliots

It's not like your current project has problem, but it seems all of google.protobuf.* types will be converted to type: boolean, format: boolean and so on.
https://github.com/elliots/protoc-gen-twirp_swagger/blob/master/genswagger/template.go#L276

In other word, It seems XXXProtobufStringValue object and them don't need to be put in definitions.
At least, XXXProtobufXXXValue will be put in definitions now but it will not be referenced from other any objects.

Thank you for reading my poor English 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants