Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle arm64 #8

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Handle arm64 #8

merged 4 commits into from
Apr 26, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 24, 2023

No description provided.

@t3chguy t3chguy added the enhancement New feature or request label Apr 24, 2023
@t3chguy t3chguy mentioned this pull request Apr 24, 2023
Merged
@t3chguy t3chguy requested a review from a team April 24, 2023 12:53
@t3chguy t3chguy self-assigned this Apr 25, 2023
andybalaam
andybalaam previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but hard for me to understand. Maybe a comment or more explanation in the names of the steps?

t3chguy added 2 commits April 26, 2023 12:08
@t3chguy
Iterate
3596329
@t3chguy
Merge remote-tracking branch 'origin/t3chguy/handle-arm64' into t3chg…
5519159 
…uy/handle-arm64

# Conflicts:
#	.github/workflows/reprepro.yaml
@t3chguy
Copy link
Member Author

t3chguy commented Apr 26, 2023

@andybalaam I changed the approach

@t3chguy t3chguy requested a review from andybalaam April 26, 2023 11:09
andybalaam
andybalaam approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@t3chguy t3chguy merged commit 085f835 into master Apr 26, 2023
@t3chguy t3chguy deleted the t3chguy/handle-arm64 branch April 26, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees

@t3chguy t3chguy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam