This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 9
Update codeowners to element-hq teams #3
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,18 @@ | ||
| * @matrix-org/element-web-reviewers | ||
| /.github/workflows/** @matrix-org/element-web-team | ||
| /package.json @matrix-org/element-web-team | ||
| /yarn.lock @matrix-org/element-web-team | ||
| * @element-hq/element-web-reviewers | ||
| /.github/workflows/** @element-hq/element-web-team | ||
| /package.json @element-hq/element-web-team | ||
| /yarn.lock @element-hq/element-web-team | ||
|
|
||
| /src/SecurityManager.ts @matrix-org/element-crypto-web-reviewers | ||
| /test/SecurityManager-test.ts @matrix-org/element-crypto-web-reviewers | ||
| /src/async-components/views/dialogs/security/ @matrix-org/element-crypto-web-reviewers | ||
| /src/components/views/dialogs/security/ @matrix-org/element-crypto-web-reviewers | ||
| /test/components/views/dialogs/security/ @matrix-org/element-crypto-web-reviewers | ||
| /src/stores/SetupEncryptionStore.ts @matrix-org/element-crypto-web-reviewers | ||
| /test/stores/SetupEncryptionStore-test.ts @matrix-org/element-crypto-web-reviewers | ||
| /src/SecurityManager.ts @element-hq/element-crypto-web-reviewers | ||
| /test/SecurityManager-test.ts @element-hq/element-crypto-web-reviewers | ||
| /src/async-components/views/dialogs/security/ @element-hq/element-crypto-web-reviewers | ||
| /src/components/views/dialogs/security/ @element-hq/element-crypto-web-reviewers | ||
| /test/components/views/dialogs/security/ @element-hq/element-crypto-web-reviewers | ||
| /src/stores/SetupEncryptionStore.ts @element-hq/element-crypto-web-reviewers | ||
| /test/stores/SetupEncryptionStore-test.ts @element-hq/element-crypto-web-reviewers | ||
|
|
||
| # Ignore translations as those will be updated by GHA for Localazy download | ||
| /src/i18n/strings | ||
| # Ignore the synapse plugin as this is updated by GHA for docker image updating | ||
| /playwright/plugins/homeserver/synapse/index.ts | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this team doesn't exist on element-hq.
Should that be created or use element-crypto for now @richvdh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should do, I just created it: https://github.com/orgs/element-hq/teams/element-crypto-web-reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it can't be a secret team - I've changed it to public but it might take a while for GH to realise and update the codeowners file check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, obviously it was because I forgot to add the team's access to the repo 🤦