Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Refactor stores and their relationship to the MatrixClientPeg #124

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 4, 2024

to avoid import cycles and webpack weirdness

Fixes element-hq/element-web#27606

to avoid import cycles and webpack weirdness

Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, thank you!

@t3chguy t3chguy added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit 197168b Oct 8, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/27606 branch October 8, 2024 09:28
dbkr added a commit that referenced this pull request Oct 10, 2024
This seems to be causing a lot of weirdness, presumably because there's
another missing thing like in #135, but I don't know what it might be and
it feels like it might take a while to find. Backing these changes out
to fix develop while we sort it out.

Fixes element-hq/element-web#28179
@dbkr dbkr mentioned this pull request Oct 10, 2024
4 tasks
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
This seems to be causing a lot of weirdness, presumably because there's
another missing thing like in #135, but I don't know what it might be and
it feels like it might take a while to find. Backing these changes out
to fix develop while we sort it out.

Fixes element-hq/element-web#28179
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console errors on startup: can't access lexical declaration 'MatrixClientPeg' before initialization
2 participants