Added a disclaimer in Notification Settings for "Mentions Only" #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
requested review from
stefanceriu,
nimau and
pixlwave
and removed request for
a team,
stefanceriu and
pixlwave
Generated by 🚫 Danger Swift against 1e84cdc |
Velin92
force-pushed
the
mauroromito/mention_only_warning
branch
from
2c93a13 to
3592f6d
Compare
nimau
reviewed
Nov 14, 2023
...s/Screens/Settings/NotificationSettingsEditScreen/NotificationSettingsEditScreenModels.swift
Show resolved
Hide resolved
nimau
approved these changes
Nov 14, 2023
Velin92
force-pushed
the
mauroromito/mention_only_warning
branch
from
0df64b9 to
656f24a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2078
The disclaimer is slightly different between the global settings and an encrypted room custom setting.
For a non ecrypted room custom settings the disclaimer will not appear (doesn't matter if accessed from the global setting or from the room settings)
If the homeserver supports MSC 4028 the disclaimer won't appear at all in any case, an API is exposed on the SDK to allow that
Requires the following PR to be merged in the Rust SDK
All the following cases are tested on a sever that does not support 4028
custom setting for a non encrypted room (no change)
custom setting for an encrypted room
custom setting for an encrypted room, from room details
global settings