Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change integrations_widgets_urls default configuration #10656

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

jaywink
Copy link
Member

@jaywink jaywink commented Aug 26, 2019

Add and prioritize the new "_matrix/integrations/v1" widget urls

As per MSC1961, add to the whitelisted integrations_widget_urls
the new paths. This allows us to switch Scalar over to use the
new path as default.

Note, the legacy "scalar-staging.riot.im" is these days just a redirect
to scalar-staging.vector.im, so there is no addition for that. It still
needs Riot side whitelisting though for existing widgets.

Refs: matrix-org/matrix-spec-proposals#1961

Provide our common integrations_widget_urls defaults for sample config

Closes: #10454

As per MSC1961, add to the whitelisted integrations_widget_urls
the new paths. This allows us to switch Scalar over to use the
new path as default.

Note, the legacy "scalar-staging.riot.im" is these days just a redirect
to scalar-staging.vector.im, so there is no addition for that. It still
needs Riot side whitelisting though for existing widgets.
@jaywink jaywink requested a review from a team August 26, 2019 07:06
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but we really should be working towards killing this setting.

@jaywink jaywink merged commit 9b7f44c into develop Aug 26, 2019
@jaywink jaywink deleted the jaywink/integrations-widget-urls branch August 26, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide sensible defaults for integrations_widgets_urls
2 participants